Add support for Razer Blackwidow v3 Pro wireless #1901

nicfix · 2022-08-29T21:24:24Z

Added partial support for BlackWidow V3 Pro wireless

What works:

The device is detected (tested on polychromatic)
All the effects work apart from ripple (disabled)

What doesn't work:

Ripple effect

What works meh:

Battery level, I still get several notifications of empty battery, same behavior as my basilisk ultimate though.

This PR is heavily inspired by the one from @GeoDoX (#1623), I thought about forking from that branch but rebasing @GeoDoX's branch proved more difficult than starting from scratch.

Partially fixes #1279

andriinuts · 2022-09-21T08:15:32Z

@z3ntu please have a look at this PR as the previous one was stuck

nicfix · 2022-10-10T19:20:49Z

@z3ntu any news for this PR?

z3ntu · 2022-10-16T09:40:24Z

driver/razerkbd_driver.c

    case USB_DEVICE_ID_RAZER_BLACKWIDOW_V3_MINI_WIRELESS:
        report.transaction_id.id = 0x9F;
        break;
+    default:
+        report.transaction_id.id = 0x1f;
+        break;


Why is this block added?

removed it for now, still keeping this "conversation" open, maybe it was super important for something

z3ntu · 2022-10-16T09:42:25Z

driver/razerkbd_driver.c

@@ -1533,7 +1549,11 @@ static ssize_t razer_attr_write_matrix_effect_reactive(struct device *dev, struc
    case USB_DEVICE_ID_RAZER_BLACKWIDOW_V3_PRO_WIRED:
        report = razer_chroma_extended_matrix_effect_reactive(VARSTORE, BACKLIGHT_LED, speed, (struct razer_rgb*)&buf[1]);
        break;
-
+    case USB_DEVICE_ID_RAZER_BLACKWIDOW_V3_PRO_WIRELESS:
+        razer_set_device_mode(usb_dev, 0x00, 0x00);


If the daemon likes to switch the device to driver mode (which I didn't check now), then maybe that should be removed if reactive effect doesn't work with it.
Overwriting the device mode here isn't great at all...

z3ntu · 2022-10-16T09:43:48Z

driver/razerkbd_driver.c

@@ -1699,7 +1718,7 @@ static ssize_t razer_attr_write_matrix_effect_static(struct device *dev, struct
        report.transaction_id.id = 0x1F;
        razer_send_payload(usb_dev, &report);
        break;
-


Please revert all these unrelated whitespace changes in this file

done it myself

daemon/openrazer_daemon/hardware/keyboards.py

z3ntu · 2022-10-16T09:45:52Z

daemon/openrazer_daemon/hardware/keyboards.py

+               'set_custom_effect', 'set_key_row', 'get_game_mode', 'set_game_mode', 'get_macro_mode', 'set_macro_mode',
+               'get_macro_effect', 'set_macro_effect', 'get_macros', 'delete_macro', 'add_macro',
+               'set_starlight_random_effect', 'set_starlight_single_effect', 'set_starlight_dual_effect',
+               # 'set_ripple_effect', 'set_ripple_effect_random_colour',


Remove the comment if it doesn't work?

stat1x · 2022-11-04T07:17:17Z

Would be cool if it gets merged.
Thanks.

YoMamasNerd · 2022-12-24T23:33:17Z

Nice, Id love to test this. Ive just got this keyboard.

Happy Holidays

z3ntu · 2023-01-09T19:56:26Z

@andriinuts @YoMamasNerd Does this PR work for you? See https://github.com/openrazer/openrazer/wiki/Building-a-package

@nicfix There's still some open comments, could you resolve them?

YoMamasNerd · 2023-01-09T21:20:33Z

I'll try it this weekend probably.
Thank you for your response @z3ntu 🙂

YoMamasNerd · 2023-01-14T13:53:53Z

@z3ntu I may need some further help to get this working. Do you have a discord or something?
The Keyboard is working in wireless mode. Sleep mode settings do not work.

Traceback (most recent call last):
  File ’/usr/lib/python3.10/site-packages/polychromatic/controller/devices.py’, line 429, in _slider_dropped
    option.apply(slider.value())
  File ’/usr/lib/python3.10/site-packages/polychromatic/backends/openrazer.py’, line 1339, in apply
    self._rdevice.set_idle_time(int(new_value) * 60)
  File ’/usr/lib/python3.10/site-packages/openrazer/client/devices/__init__.py’, line 460, in set_idle_time
    self._dbus_interfaces[’power’].setIdleTime(idle_time)
  File ’/usr/lib/python3.10/site-packages/dbus/proxies.py’, line 141, in __call__
    return self._connection.call_blocking(self._named_service,
  File ’/usr/lib/python3.10/site-packages/dbus/connection.py’, line 652, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
dbus.exceptions.DBusException: org.freedesktop.DBus.Python.PermissionError: Traceback (most recent call last):
  File ’/usr/lib/python3.10/site-packages/dbus/service.py’, line 715, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File ’/usr/lib/python3.10/site-packages/openrazer_daemon/dbus_services/dbus_methods/mamba.py’, line 51, in set_idle_time
    with open(driver_path, ’w’) as driver_file:
PermissionError: [Errno 13] Permission denied: ’/sys/devices/pci0000:00/0000:00:01.3/0000:02:00.0/usb1/1-3/1-3:1.2/0003:1532:025C.0006/device_idle_time’

Battery reporting is working with the keyboard.

And my mouse (Deathadder v3 Pro) is not getting recognized anymore. May be a result of being so far behind the official repo.

z3ntu · 2023-01-15T11:34:49Z

@YoMamasNerd Telegram or Matrix (or IRC if necessary): https://github.com/openrazer/openrazer/wiki/Community-chat

Regarding this error, looks like the device declares it supports set_idle_time but device_idle_time is not implemented in kernel driver so it fails. This should be corrected (how depends on whether the firmware supports this command or not)

What is not working: - Battery level in the notification - Ripple effect (all the others work correctly)

YoMamasNerd · 2023-01-15T16:46:12Z

Things that work

Effects
changing brightness
updating battery level
low power mode settings

Things that does not work

setting "Sleep mode after"
updating charging status without reloading Polychromatic
Battery warning shows Labeled tag

z3ntu · 2023-04-27T20:28:31Z

Has there been any progress on the non-working items?

YoMamasNerd · 2023-04-27T21:40:32Z

Not yet. I've been too busy to fix the issues since they are not breaking anything for me.
I might be able to look into resolving the issues this weekend.

z3ntu · 2023-04-30T14:11:39Z

Closing in favor of #2056

nicfix marked this pull request as ready for review August 29, 2022 21:26

nicfix changed the title ~~Razer blackwidow v3 pro wireless~~ Add support for Razer Blackwidow v3 Pro wireless Oct 10, 2022

z3ntu added the Device Support label Oct 16, 2022

z3ntu reviewed Oct 16, 2022

View reviewed changes

z3ntu mentioned this pull request Oct 16, 2022

Added support for BlackWidow V3 Pro (Wireless) #1623

Closed

z3ntu reviewed Oct 16, 2022

View reviewed changes

daemon/openrazer_daemon/hardware/keyboards.py Outdated Show resolved Hide resolved

z3ntu reviewed Oct 16, 2022

View reviewed changes

z3ntu added the In Progress label Nov 5, 2022

z3ntu force-pushed the razer_blackwidow_v3_pro_wireless branch from c5c0a37 to 03ed6d0 Compare January 15, 2023 15:05

WIP Add support for Razer BlackWidow V3 Pro

4d241d9

What is not working: - Battery level in the notification - Ripple effect (all the others work correctly)

z3ntu force-pushed the razer_blackwidow_v3_pro_wireless branch from 03ed6d0 to 4d241d9 Compare January 15, 2023 15:10

nightsky30 mentioned this pull request Feb 21, 2023

Support for Blackwidow V3 Pro wireless(PID1532:025c) on Ubuntu 20.04 #2024

Closed

z3ntu closed this Apr 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Razer Blackwidow v3 Pro wireless #1901

Add support for Razer Blackwidow v3 Pro wireless #1901

nicfix commented Aug 29, 2022

andriinuts commented Sep 21, 2022

nicfix commented Oct 10, 2022

z3ntu Oct 16, 2022

z3ntu Jan 15, 2023

z3ntu Oct 16, 2022

z3ntu Oct 16, 2022

z3ntu Jan 15, 2023

z3ntu Oct 16, 2022

stat1x commented Nov 4, 2022

YoMamasNerd commented Dec 24, 2022

z3ntu commented Jan 9, 2023 •

edited

YoMamasNerd commented Jan 9, 2023

YoMamasNerd commented Jan 14, 2023 •

edited

z3ntu commented Jan 15, 2023 •

edited

YoMamasNerd commented Jan 15, 2023

z3ntu commented Apr 27, 2023

YoMamasNerd commented Apr 27, 2023

z3ntu commented Apr 30, 2023

Add support for Razer Blackwidow v3 Pro wireless #1901

Add support for Razer Blackwidow v3 Pro wireless #1901

Conversation

nicfix commented Aug 29, 2022

andriinuts commented Sep 21, 2022

nicfix commented Oct 10, 2022

z3ntu Oct 16, 2022

Choose a reason for hiding this comment

z3ntu Jan 15, 2023

Choose a reason for hiding this comment

z3ntu Oct 16, 2022

Choose a reason for hiding this comment

z3ntu Oct 16, 2022

Choose a reason for hiding this comment

z3ntu Jan 15, 2023

Choose a reason for hiding this comment

z3ntu Oct 16, 2022

Choose a reason for hiding this comment

stat1x commented Nov 4, 2022

YoMamasNerd commented Dec 24, 2022

z3ntu commented Jan 9, 2023 • edited

YoMamasNerd commented Jan 9, 2023

YoMamasNerd commented Jan 14, 2023 • edited

z3ntu commented Jan 15, 2023 • edited

YoMamasNerd commented Jan 15, 2023

z3ntu commented Apr 27, 2023

YoMamasNerd commented Apr 27, 2023

z3ntu commented Apr 30, 2023

z3ntu commented Jan 9, 2023 •

edited

YoMamasNerd commented Jan 14, 2023 •

edited

z3ntu commented Jan 15, 2023 •

edited