Remove macro support#2337
Draft
z3ntu wants to merge 4 commits into
Draft
Conversation
Member
|
Removing support would close these 6+ year old issues: |
lah7
added a commit
to polychromatic/polychromatic
that referenced
this pull request
Nov 1, 2024
Only show this button if the running OpenRazer version has macro support. We display a button with an informational message on how to use their daemon feature, only show if relevant. This very old code is now deprecated: openrazer/openrazer#2337
This was referenced Apr 8, 2025
z3ntu
force-pushed
the
remove-macro
branch
2 times, most recently
from
December 15, 2025 12:12
ddb21c8 to
856d8ba
Compare
This code has been not touched in a long time, basically deprecated. Neither polychromatic nor RazerGenie use these APIs so it's questionable anyone actually uses this. For any serious purpose the macro code is way too limited anyways and users should use something like https://github.com/sezanzeb/input-remapper Remove it. The daemon bits still remain as of this commit, they will be removed later since it's a bit interwoven with ripple.
This code has been not touched in a long time, basically deprecated. Neither polychromatic nor RazerGenie use these APIs so it's questionable anyone actually uses this. For any serious purpose the macro code is way too limited anyways and users should use something like https://github.com/sezanzeb/input-remapper Remove it.
It's time for it to go. See previous commits for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been not touched in a long time, basically deprecated.
Neither polychromatic nor RazerGenie use these APIs so it's questionable
anyone actually uses this. For any serious purpose the macro code is way
too limited anyways and users should use something like
https://github.com/sezanzeb/input-remapper
Remove it.
Pretty sure this currently breaks ripple, probably removing too much code, need to keep some of key_manager, ripple_effect.py uses this in key_list