Entering domain without scheme prefix crashes the app

[ebariaux]

Starting with a fresh app, the "enter domain" screen is displayed.
Enter a string with an IP and port but no scheme e.g. "192.168.1.1:8080".
App crashes with a forced unwrap (building a URL from that string fails).

Add unit tests to prove the crash.
Fix the code to use https:// as default scheme is none is present.

[MartinaeyNL]

I have a similar issue opened in console-android for its generic OpenRemote app; openremote/console-android#22
For example. the same numeric IP issue exists, but also cases where *.openremote.app was appended without a need for it.
Might be nice to improve the URL input for both, as the validation logic should be similar.

And I don't know why, but currently the validations seems to be better on iOS for me. But I might be wrong.

[ebariaux]

Those are really 2 different code bases. For some parts, Michael did both sides but for others, I worked on iOS and he worked on Android.
I could maybe take a look at both and align the behaviour.
One good way to do it is to have a set of unit tests that document the expect behaviour on both sides.

[ebariaux]

! crash is only if a port is also provided, having just an IP address works OK e.g. 192.168.1.1

[MartinaeyNL]

Makes sense. I think I was checking with <local IP>:8080 indeed.
Would be nice if it can support custom ports as well. Most common ports would be 80, 443 and 8080
@ebariaux

Oh, a different question; Is SSL / proxy setup required for the iOS console to work?

[ebariaux]

Also see openremote/console-ios-app#30 PR

[ebariaux]

@MartinaeyNL
All ports are supported, if invalid one in the end user gets an error panel.

TLS is required by the iOS console. If you want to go around that, you need to add specific exception to the project and re-compile the code.