docs(README): fix helm install command instruction#106
Merged
Conversation
Contributor
|
Hi @Horgix ! Thanks for the fix ! 😉 CI is failing though, could you make sure that all of your commits are signed (commit signature is mandatory for all CNCF projects) ? You'll have to do look something like : git rebase HEAD~1 --signoff
git push --force-with-lease origin readme-helm-install-ociLet me know if you need any help, thanks ! 🙏 |
Contributor
|
Note: codegen CI step is failing as well but it's not caused by your PR. It should be fixed once #107 gets merged. |
Horgix
force-pushed
the
readme-helm-install-oci
branch
from
b49b145 to
4b28a64
Compare
Which was failing with `Error: INSTALLATION FAILED: must either provide a name or specify --generate-name` as-is Signed-off-by: Alexis Horgix Chotard <github+reports-api@foss.horgix.fr>
Horgix
force-pushed
the
readme-helm-install-oci
branch
from
2ae5050 to
b20c5c4
Compare
Contributor
Author
|
Hey @lucchmielowski , DCO passes now 🙂 Sorry for the delay! I guess CI will pass again and everything here will be green soon enough - thanks for looking at the PR! |
lucchmielowski
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As-is, the
helm installinstruction in the README fails with:given it misses the
[NAME]mandatory argument. This PR fixes that.