Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed minor grammatical errors in the README.markdown file #117

Merged
merged 5 commits into from May 21, 2012

Conversation

Projects
None yet
3 participants
Contributor

zhuzhaoyuan commented May 21, 2012

  1. the first letter of Lua should be capitalized
  2. other grammatical errors or typos

@chaoslawful chaoslawful added a commit that referenced this pull request May 21, 2012

@chaoslawful chaoslawful Merge pull request #117 from zhuzhaoyuan/master
fixed minor grammatical errors in the README.markdown file
0538286

@chaoslawful chaoslawful merged commit 0538286 into openresty:master May 21, 2012

Owner

agentzh commented May 22, 2012

It is incorrect to edit README.markdown directly because it is generated automatically from docs/HttpLuaNginxModule.wiki by the wiki2markdown.pl script in the nginx-devel-utils project:

https://github.com/agentzh/nginx-devel-utils

Please edit docs/HttpLuaNginxModule.wiki or the wiki page on wiki.nginx.org (http://wiki.nginx.org/HttpLuaModule ) instead.

Owner

agentzh commented May 22, 2012

I've updated wiki2markdown.pl to emit a leading markdown comment that states the output file is generated automatically so as to prevent future confusions:

openresty/openresty-devel-utils@cfc9c16

Sorry for the frustrations here :P

Contributor

zhuzhaoyuan commented May 22, 2012

Sorry I didn't notice that. I'll issue a new pull request against docs/HttpLuaNginxModule.wiki later.
Thanks a lot!

Contributor

chaoslawful commented May 22, 2012

Oops...I didn't notice that. Sorry...

Owner

agentzh commented May 22, 2012

Such trivial edits should go to the wiki page directly because doc/HttpLuaModule.wiki is also synchronized (manually) from the wiki site:

http://wiki.nginx.org/HttpLuaModule

Thank you for your contributions!

Contributor

zhuzhaoyuan commented May 22, 2012

Hi @agentzh!
I've issued a new pull request as you suggested: chaoslawful#118
Could you please review it?
Thanks!

@agentzh agentzh added a commit that referenced this pull request May 23, 2012

@agentzh agentzh Merge pull request #118 from zhuzhaoyuan/master
Issue a new pull request (Was: #117) for various documentation improvements.
69a3d89
Owner

agentzh commented May 23, 2012

On Tue, May 22, 2012 at 11:58 PM, Joshua Zhu
reply@reply.github.com
wrote:

Hi @agentzh!
I've issued a new pull request as you suggested: chaoslawful#118
Could you please review it?

Merged. Thanks for your hard work!

Best regards,
-agentzh

@bakins bakins pushed a commit to bakins/lua-nginx-module that referenced this pull request Jun 30, 2012

@chaoslawful chaoslawful Merge pull request #117 from zhuzhaoyuan/master
fixed minor grammatical errors in the README.markdown file
986381d

@bakins bakins pushed a commit to bakins/lua-nginx-module that referenced this pull request Jun 30, 2012

@agentzh agentzh Merge pull request #118 from zhuzhaoyuan/master
Issue a new pull request (Was: #117) for various documentation improvements.
3c5d615

@agentzh agentzh added a commit that referenced this pull request Oct 1, 2015

@agentzh agentzh bugfix: the user specified ./configure's --with-cc-opt and --with-ld-…
…opt might override the LUAJIT_INC/LUAJIT_LIB and LUA_INC/LUA_LIB environment settings. thanks Julian Gonggrijp for the report in #117.
600ddd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment