-
Notifications
You must be signed in to change notification settings - Fork 2.1k
1.9.0 Compatibility Fixes (See #497, #498, #499) #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See the second commit, cddb16d. The full code block is:
|
Ok then ;) |
Btw, as reference for @agentzh : http://hg.nginx.org/nginx/rev/187aa751ad62 |
btw, @charlesportwoodii |
Although, you can combine them both in the single commit with the same way ;) |
cddb16d
to
e5ec660
Compare
Rebased to a single commit, and cleaned up some newline/whitespace as requested. Let me know if you would like to see anything else. |
Ah, I see what you're talking about now. I was following the coding style @agentzh had in both files:
To
Let me know if you want to keep it as is, or strip out all the newlines from the pre-processor block. I'm fine with either - just trying to following whatever convention is already setup. =)
|
e5ec660
to
29898f5
Compare
Flattened down as requested in 29898f5
|
(#503 is a duplicate of this.) |
Any update on the status of this ever being included/merged? |
Still waiting for this to be fixed... :( |
@charlesportwoodii Thanks for the patch! But will you restore the original empty lines (which were there for better readability)? Thanks! |
Oh, BTW, sorry for the delay on my side. I've been on my long vacation in China where I don't have sane Internet access for most of the time. Alas. |
Btw, @charlesportwoodii, as I previously said, please don't restore trailing whitespaces on empty lines (that, actually, was the original issue) 😉 |
@msva Yeah, line-trailing whitespaces should always be removed :) |
…R. Portwood II for the original patch in #500.
Applied a modified version of the patch to master. Thank you all, guys. |
it is very strange, because I just built it fine on about 10 servers in a row |
@msva my fault.UPdate - all works. |
Fixes compilation issue outlined in #499.
Edit
Just saw #497 and #498. This patch might be a little cleaner than that as it maintains compatibility with 1.3->1.8, rather than just dropping support for everything less.