change param expire to int64 #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@gcliupeng Travis CI is failing. Better point lua-nginx-module to your own branch for now? Thanks! |
Member
|
@gcliupeng Also, better add a test case to cover this fix? Thanks! |
Member
|
Hum, this is already addressed by #170 opened since January (which has a test case and a sister PR on lua-nginx-module as well) If we want to switch |
Member
|
Addressed by #170 which has been merged for some time already. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when use the new shdict api in resty/core，the expire may not process correctly，it use type int to story expire but not uint64 as before。when the expire is large，for example 10000000，it goes wrong。I also change the function in the c file