Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Feature request: option to change default quote style for set_quote_sql_str #1

Closed
cwells opened this Issue Aug 17, 2010 · 1 comment

Comments

Projects
None yet
2 participants

cwells commented Aug 17, 2010

The extra "for" parameter causes incompatibilities with other modules, for instance:

array_map_op set_quote_sql_str for=pg $array;

generates an error.

It would be nice if default of MySQL could be changed with directive, e.g.:

set_quote_style pgsql;      ## or set_quote_style mysql
array_map_op set_quote_sql_str $array;
Owner

agentzh commented Aug 18, 2010

Yeah, I've also fixed it in v0.12. Now we no longer support the for=pg option in the set_quote_sql_str directive, it will always stick to mysql's quoting method. For PostgreSQL literals, we introduce a new set_quote_pgsql_str directive that can be combined with ngx_array's array_map_op, for instance,

array_map_op set_quote_pgsql_str $my_array;

Could you try this out?

Thanks!

@kriegsmanj kriegsmanj pushed a commit to kriegsmanj/set-misc-nginx-module that referenced this issue Apr 7, 2016

@spoelwijk spoelwijk Merge pull request #1 from openresty/master
Merge back openresty master to leaseweb fork
381d621

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment