Skip to content

Conversation

@bryceatmoderne
Copy link
Contributor

@bryceatmoderne bryceatmoderne commented May 23, 2024

What's changed?

Added fork of org.eclipse.jgit.ssh.jsch to support JSch-based ssh transport git requests

What's your motivation?

Provides an alternative to process-based ssh requests using TransportGitSsh

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

@sambsnyd @timtebeek

Have you considered any alternatives or workarounds?

No

Any additional context

Swapped com.jcraft.jsch dependency with com.github.mwiede for support of current SSH key types

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@bryceatmoderne bryceatmoderne self-assigned this May 23, 2024
github-actions[bot]

This comment was marked as outdated.

@timtebeek
Copy link
Member

timtebeek commented May 23, 2024

Can't say I know much about how we use this for a meaningful review; does this relate to this issue updated yesterday?

Perhaps @knutwannheden might know more than me for a review.

@bryceatmoderne bryceatmoderne merged commit 629b2b5 into main May 23, 2024
@bryceatmoderne bryceatmoderne deleted the add-jgit-ssh-jsch branch May 23, 2024 16:14
@okundzich
Copy link
Member

Would you provide a description for this change? @bryceatmoderne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants