Skip to content

Conversation

@shanman190
Copy link

What's changed?

Added support for generation of Git binary patches using the literal format style.

What's your motivation?

There is a need to support representing binary files within a patch file.

Anything in particular you'd like reviewers to focus on?

This diverges us from upstream JGit which does not support writing Git binary patch files at all (it does support reading and applying them). The changes are minimally invasive, but would pose merge conflicts against the upstream. This probably isn't a large concern given we're needing to support Java 8+ (thus the reason for forking the project originally).

Anyone you would like to review specifically?

Anybody

Have you considered any alternatives or workarounds?

We could externalize the changes into new classes or place these updates further downstream in rewrite proper, but this felt like the right place to at least get started with a review.

Any additional context

N/A

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Nov 11, 2025
@shanman190 shanman190 marked this pull request as draft November 12, 2025 16:12
@Jammy-Louie Jammy-Louie marked this pull request as ready for review November 24, 2025 19:26
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Review

Development

Successfully merging this pull request may close these issues.

3 participants