Naming conflict in InstanceOfPatternMatch
#739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder recipe examples and update parameters based on automated refactoring 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add example to examples.yml demonstrating pattern variable naming conflict scenario - Add @DocumentExample annotation to the primary test case 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
| class Foo { | ||
| void bar(Object o1, Object o2) { | ||
| if (o1 instanceof LeftNode node2 && o2 instanceof RightNode node3) { |
There was a problem hiding this comment.
Surprising to see node2 and node3 before node and node1.
There was a problem hiding this comment.
Yes that slightly annoyed me as well, but figured since we're already a few levels deep into edge cases (classes with the same suffix, used in binaries, with an else of overlapping instanceof expressions) I didn't want to explore how to switch those around and risk potentially breaking other logic that had assumed a particular processing order. From a brief look into it it's not as easy as moving down a super.visit call unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstanceOfPatternMatch#619