Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow Gradle AddDependency to add dependencies to the top-level dependencies block #4181

Merged
merged 1 commit into from
May 9, 2024

Conversation

shanman190
Copy link
Contributor

What's changed?

Due to the Groovy compiler misinterpreting receiver classes for the dependencies block, this can result in the gradle.AddDependency recipe placing new dependencies improperly.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Just the pattern of using a Predicate from the recipe standpoint as the mechanism with which to invert the control flow and allow more specific insertion points from a dependency standpoint.

Anyone you would like to review specifically?

Anybody who wants to double check the work.

Have you considered any alternatives or workarounds?

None

Any additional context

None

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@shanman190 shanman190 merged commit 6db9201 into main May 9, 2024
1 check passed
@shanman190 shanman190 deleted the fix/gradle-add-dependency branch May 9, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants