Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests inside librecores CI docker image #10

Merged
merged 4 commits into from Jun 11, 2019

Conversation

@Nancy-Chauhan
Copy link

commented Jun 9, 2019

Goal : This will create shared tooling of Librecores CI image with or1k_marocchino repository.
It is also in reference to the issue openrisc/mor1kx#81.

@Nancy-Chauhan

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

@oleg-nenashev @stffrdhrn I have created a PR in reference to our conversation on openrisc/mor1kx#82 for doing the similar changes in or1k_marocchino core.

@stffrdhrn
Copy link
Member

left a comment

You created a few commits that just have text resolving errors. That is not very meaningful. Some points.

  1. Commit messages should explain what you are doing and why.
  2. It would be good to explain what error each issue is fixing, because in the future this change might cause an issue and it would be good to know why it was done.
  3. Learn about commit squashing, usually commits like typo fixes and test fixes can be squashed, so do that.
@stffrdhrn

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

I think this looks good. Can you add some documentation in the README.md under the testing section that links to the librecores-ci image and maybe some details about what it is.

@Nancy-Chauhan

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

@stffrdhrn Yes I am sorry for the commit messages, I will squash it. I will also add some documentation in the README.md. Thank you for your feedback

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved .travis/Dockerfile Outdated
@stffrdhrn
Copy link
Member

left a comment

Thanks for the changes. It looks good a few comments.

Show resolved Hide resolved README.md
README.md Outdated
@@ -51,6 +51,8 @@ Integration (CI) suite running in [travis ci](travis-ci.org). This currently co

Status: [![Build Status](https://travis-ci.org/openrisc/or1k_marocchino.svg?branch=master)](https://travis-ci.org/openrisc/or1k_marocchino)

[Librecores-CI](https://github.com/librecores/docker-images/tree/master/librecores-ci) docker image is used for testing and continous integration. Librecores CI image includes many common EDA tools such as Icarus Verilog, Verilator, Yosys and also target the FuseSoC use cases. In the travis flow `or1k-test` runs inside a Librecores-CI docker container.

This comment has been minimized.

Copy link
@stffrdhrn

stffrdhrn Jun 11, 2019

Member

Maybe you should just look to.
https://github.com/librecores/docker-images

Can you split this line up a bit. Try to limit a line to about 80 characters. It sould be consistent with other blocks in the readme.

Maybe above mention "... suite running a librecores-ci docker container in Travis ci...."

This comment has been minimized.

Copy link
@Nancy-Chauhan

Nancy-Chauhan Jun 11, 2019

Author

Did the changes. Please Let me know if it is okay. Thank you

@stffrdhrn stffrdhrn merged commit a327f75 into openrisc:master Jun 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stffrdhrn

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thanks I merged this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.