Tag new versions sequentially#114
Merged
Merged
Conversation
By moving the tag-new-version job into a new workflow, and making this workflow dependant on the CI workflow, we ensure that new versions are tagged sequentially. Doing so removes the risk of a race condition tagging new versions in an incorrect order. As a bonus, we also run the CI workflow more frequently: not only on push to the main branch, but also following several other events. Doing so ensures that new versions are correct, insofar as the check, test, and test-integration jobs are concerned. Fixes #113
We add a .png extension to fix a ProjectValidationError.
alarthast
reviewed
Mar 4, 2025
| branches: | ||
| - main | ||
|
|
||
| concurrency: tag-new-version |
There was a problem hiding this comment.
This new Slack conversation supersedes the previous one. We are now happy with the default behaviour of concurrency regarding cancelling/queuing workflows, as it will give us one-to-one relationships between PRs and tags most of the time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving the tag-new-version job into a new workflow, and making this workflow dependant on the CI workflow, we ensure that new versions are tagged sequentially. Doing so removes the risk of a race condition tagging new versions in an incorrect order.
As a bonus, we also run the CI workflow more frequently: not only on push to the main branch, but also following several other events. Doing so ensures that new versions are correct, insofar as the check, test, and test-integration jobs are concerned.
And as another bonus, we fix a ProjectValidationError.
Of course, in a more important repository (and to help future archaeologists understand what we changed and why we changed it), we'd split the fix and the two bonuses into three separate PRs. However, this isn't an important repository!
Fixes #113