This repository was archived by the owner on Jun 26, 2025. It is now read-only.
Add place_of_death #728
Merged
Add place_of_death #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebkwok
commented
Jan 28, 2022
| @@ -1804,6 +1804,8 @@ def patients_with_these_codes_on_death_certificate( | |||
| column_definition = "MIN(dod)" | |||
| elif returning == "underlying_cause_of_death": | |||
| column_definition = "MIN(icd10u)" | |||
| elif returning == "place_of_death": | |||
| column_definition = "MIN(Place_of_occurrence)" | |||
There was a problem hiding this comment.
This arbitrarily uses MIN to handle possible duplicates with different Place_of_occurrence in the same way as icd10u. This appears to be moot now - I checked the ONS_Deaths table and there are no duplicate Patient IDs. However, just in case that changes, we should probably continue to handle duplicates as we've done before
iaindillingham
approved these changes
Jan 31, 2022
rebkwok
force-pushed
the
place_of_death
branch
from
8b5f21f to
7f9265e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
From TPP: