This repository was archived by the owner on Jun 26, 2025. It is now read-only.
Conversation
iaindillingham
approved these changes
Mar 8, 2022
Member
iaindillingham
left a comment
There was a problem hiding this comment.
This is really clear. Thanks for commenting on the adjustment, and making it explicit in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #742
patients.admitted_to_hospitalalready returnsdays_in_critical_care, however this will return the number of days for the first or last matching admission.This allows the return options of
total_critical_care_days_in_periodandtotal_bed_days_in_periodby summing the days for all admissions during the period. In the case where there are two or more admissions recorded with the same admission date, we take the max number of days to avoid counting the sames days more than once.For
total_bed_days_in_period, the return value required is number of days, but the data recorded is number of nights (sometimes 0, which counts as one bed day).