Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounding instructions to disclosure docs #895

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

LFISHER7
Copy link
Contributor

@LFISHER7 LFISHER7 commented Aug 1, 2022

This could be expanded on in the future, but provides at least some instruction for rounding.

@render
Copy link

render bot commented Aug 1, 2022

@render
Copy link

render bot commented Aug 1, 2022

Your Render PR Server at https://opensafely-documentation-pr-895.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-cbjq47fho1kvb2r3046g.

@StevenMaude
Copy link
Contributor

suggestion: Would it be useful to have a concrete example with fictitious data? This could show tables before and after the redaction and rounding process.

This might help illuminate the details, in case a reader either misinterprets the instructions or is otherwise unclear on the meaning.

It's possible to add simple tables in the Markdown without too much work.

@StevenMaude
Copy link
Contributor

Otherwise, the text looks fine. But better for someone who knows our disclosure controls well to approve it 🔍

@LFISHER7
Copy link
Contributor Author

LFISHER7 commented Aug 1, 2022

Thanks @StevenMaude , that's a good suggestion, I'll get something added

@render
Copy link

render bot commented Aug 1, 2022

Your Render PR Server at https://opensafely-documentation-pr-895.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-cbjq47fho1kvb2r3046g.

@LFISHER7 LFISHER7 requested a review from Jongmassey August 3, 2022 13:32
Copy link
Contributor

@Jongmassey Jongmassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the text and example are excellent, and I look forward to referring researchers to this in future!

@LFISHER7 LFISHER7 merged commit c58edb1 into main Aug 4, 2022
@LFISHER7 LFISHER7 deleted the add-rounding-docs branch August 4, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants