Permalink
Browse files

Ignore dimension when evaluating control modules mixed with geometry …

…children. Fixes #229
  • Loading branch information...
1 parent ffae0bb commit bc7ff5aa8d73ff08bd847bc8d0f41dc26deee54e @kintel kintel committed Dec 27, 2012
View
1 src/CGALEvaluator.cc
@@ -130,6 +130,7 @@ CGAL_Nef_polyhedron CGALEvaluator::applyHull(const CgaladvNode &node)
const CGAL_Nef_polyhedron &chN = item.second;
// FIXME: Don't use deep access to modinst members
if (chnode->modinst->isBackground()) continue;
+ if (chN.dim == 0) continue; // Ignore object with dimension 0 (e.g. echo)
if (dim == 0) {
dim = chN.dim;
}
View
4 testdata/scad/features/control-hull-dimension.scad
@@ -0,0 +1,4 @@
+hull() {
+ circle(1);
+ echo(1);
+}
View
BIN tests/regression/cgalpngtest/control-hull-dimension-expected.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
5 tests/regression/dumptest/control-hull-dimension-expected.txt
@@ -0,0 +1,5 @@
+ hull() {
+ circle($fn = 0, $fa = 12, $fs = 2, r = 1);
+ group();
+ }
+
View
BIN tests/regression/opencsgtest/control-hull-dimension-expected.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN tests/regression/throwntogethertest/control-hull-dimension-expected.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit bc7ff5a

Please sign in to comment.