Review and test deps tracking / make #244

Open
kintel opened this Issue Jan 17, 2013 · 2 comments

3 participants

@kintel
openscad member

See #243 for a recent issue related to this.

-> Review the code
-> Add some tests to the test suite (or manual checklists)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@donbright
openscad member

Yeah my patch definitely does not address any underlying issues. . . it was just to maintain the same behavior it currently has (with DXF), but not to crash.

I'm not sure why it needs to distinguish the 'type of output file' at all other than as some type of verification that it's actually dealing with a valid output file... but it would be nice to be more explicit.

@nestibal

I may add one bug in the buildings of the .deps file. If one dependency contains a space in its absolute path, the *.deps will be faulty since the space won't be correctly escaped.

@kintel kintel added a commit that referenced this issue Oct 14, 2014
@kintel kintel #244 Escape spaces in filenames f7b15e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment