Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Focus Error Log with Screen Reader/Keyboard #3509

Closed
jage9 opened this issue Dec 2, 2020 · 3 comments
Closed

Unable to Focus Error Log with Screen Reader/Keyboard #3509

jage9 opened this issue Dec 2, 2020 · 3 comments

Comments

@jage9
Copy link

jage9 commented Dec 2, 2020

Using OpenSCAD 2020.11.30.ci6340
With a screen Reader (I am using NVDA), there seems to be no way to bring keyboard focus to the error log, and potentially other windows.

From the main window, create code that causes an error and press F6.
Expected result: The error is displayed, and either focus would jump straight to the error or there would be a way to move focus manually.

Current result: The error is displayed, but screen reader-specific navigation commands are needed to read the text.

There are a couple of possible ideas. First, adding Ctrl+Tab and Ctrl+Shift+Tab to move between windows would allow for keyboard access. Additional shortcuts to jump to specific windows would also be helpful.

Once in an additional window, such as the error log, it is possible to use the arrow keys to move through the list of errors. It would be good to allow for pressing enter to move focus to the line of the error, if an equivalent feature is available with the mouse.

@jage9 jage9 changed the title Unable to Focus Error Log with Screen Reader Unable to Focus Error Log with Screen Reader/Keyboard Dec 2, 2020
@t-paul
Copy link
Member

t-paul commented Dec 12, 2020

Could you give this version a try?

Windows 64-bit ZIP
Windows 64-bit Installer

This adds a Window menu and enables jump to source from the ErrorLog window by pressing the Enter key. I've added Prev/Next window too, but for now we can't use Ctrl+Tab and Ctrl+Shift+Tab as those are already used to navigate editor tabs. There's a change pending which makes the keyboard shortcuts configurable.

@t-paul t-paul added this to To do (get into master) in 2021.01 via automation Dec 12, 2020
@MichaelAtOz
Copy link
Member

Works on W7.

enables jump to source from the ErrorLog window by pressing the Enter key.

That confused me for a while, I thought after Window/Error-log, press Enter to go to Editor...

:|

No, Window-Error-log, scroll through the list of errors (with Up/Down keys) press Enter to go to the line with that error.
I haven't played with Error-log.

Thought-bubble, listing all the Editor tabs on the bottom of the 'Window' menu would also aid navigation...

@t-paul t-paul closed this as completed in d3239b1 Dec 13, 2020
t-paul added a commit that referenced this issue Dec 13, 2020
Add window menu to allow keyboard access to all docked windows (fixes #3509).
2021.01 automation moved this from To do (get into master) to Ready (pick to branch pending) Dec 13, 2020
@t-paul
Copy link
Member

t-paul commented Dec 13, 2020

I wanted to keep things minimal so we can include as accessibility fix for the release. It would be great to collect more ideas for improving accessibility.

@t-paul t-paul moved this from Ready (pick to branch pending) to Done in 2021.01 Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2021.01
  
Done-RC1-to-RC3
Development

No branches or pull requests

3 participants