Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020.12-RC3 - Quit with unsaved changes - Save-all doesn't quit #3556

Closed
MichaelAtOz opened this issue Dec 28, 2020 · 0 comments
Closed

2020.12-RC3 - Quit with unsaved changes - Save-all doesn't quit #3556

MichaelAtOz opened this issue Dec 28, 2020 · 0 comments
Projects

Comments

@MichaelAtOz
Copy link
Member

MichaelAtOz commented Dec 28, 2020

2019.05 File/Quit with unsaved edits, dialogue box 'The document has been modified. Do you want to save your changes?', click Save, saves file and quits.

2020.12-RC3, 'Some of the tabs are modified. All unsaved changes will be lost.', click Save-All, saves (shown in console), but does not quit.
Discard does quit.

This is a matter of taste, but...
'Some of the tabs are modified.', sounds a bit odd, 'Some tabs have been modified.' or better 'Some tabs have unsaved changes.' maybe??

@t-paul t-paul added this to To do (get into master) in 2021.01 via automation Jan 2, 2021
@t-paul t-paul closed this as completed in 1965a30 Jan 3, 2021
t-paul added a commit that referenced this issue Jan 3, 2021
Close window on successful save all (fixes #3556).
2021.01 automation moved this from To do (get into master) to Ready (pick to branch pending) Jan 3, 2021
@t-paul t-paul moved this from Ready (pick to branch pending) to Done-RC5 in 2021.01 Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2021.01
  
Done-RC5
Development

No branches or pull requests

1 participant