2020.12-RC3 - Quit with unsaved changes - Save-all doesn't quit #3556

MichaelAtOz · 2020-12-28T04:00:49Z

2019.05 File/Quit with unsaved edits, dialogue box 'The document has been modified. Do you want to save your changes?', click Save, saves file and quits.

2020.12-RC3, 'Some of the tabs are modified. All unsaved changes will be lost.', click Save-All, saves (shown in console), but does not quit.
Discard does quit.

This is a matter of taste, but...
'Some of the tabs are modified.', sounds a bit odd, 'Some tabs have been modified.' or better 'Some tabs have unsaved changes.' maybe??

Close window on successful save all (fixes #3556).

t-paul added this to To do (get into master) in 2021.01 via automation Jan 2, 2021

t-paul closed this as completed in 1965a30 Jan 3, 2021

t-paul added a commit that referenced this issue Jan 3, 2021

Merge pull request #3576 from openscad/fix-save-all

a980a3a

Close window on successful save all (fixes #3556).

2021.01 automation moved this from To do (get into master) to Ready (pick to branch pending) Jan 3, 2021

t-paul moved this from Ready (pick to branch pending) to Done-RC5 in 2021.01 Jan 3, 2021

t-paul added a commit that referenced this issue Jan 3, 2021

Close window on successful save all (fixes #3556).

7bff6b5

tombsar mentioned this issue Jan 3, 2021

Closing app when there are unsaved files: After selection "Save All" app stays open #3577

Closed

2020.12-RC3 - Quit with unsaved changes - Save-all doesn't quit #3556

2020.12-RC3 - Quit with unsaved changes - Save-all doesn't quit #3556

Comments

MichaelAtOz commented Dec 28, 2020 • edited by kintel

MichaelAtOz commented Dec 28, 2020 •

edited by kintel