*nef3* test failures with CGAL 5.2 + security patch

[leo-lb]

Hello!

With this security patch applied on openscad's dep CGAL 5.2: CGAL/cgal#5371 (fixes CVE-2020-28601, CVE-2020-28636, CVE-2020-35628 and CVE-2020-35636)

I obtain these test failures:

447/1315 Testing: cgalpngtest_nef3_broken
447/1315 Test: cgalpngtest_nef3_broken
Command: "/gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/test_cmdline_tool.py" "--comparator=" "-c" "/gnu/store/vlix7fclb7ifjgmxgpwr1pvraff89w7b-imagemagick-6.9.11-48/bin/convert" "-s" "png" "-t" "cgalpngtest" "-f" "nef3_broken" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad" "--render" "-o"
Directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests
"cgalpngtest_nef3_broken" start time: Mar 05 21:22 UTC
Output:
----------------------------------------------------------
nef3_broken
run_test() cmdline: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad --render -o /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/cgalpngtest/nef3_broken-actual.png
using font directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/ttf
stderr output: CGAL warning: check violation!
Expression : false
File       : /gnu/store/dsajl7cc1mm4sfl6kzv9yqn8vccanc0l-cgal-5.2/include/CGAL/Nef_3/SNC_io_parser.h
Line       : 1480
Explanation: SNC_io_parser::read: error in edge line
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html

Error: openscad failed with return code -11

Test time =   0.05 sec
----------------------------------------------------------
Test Failed.
"cgalpngtest_nef3_broken" end time: Mar 05 21:22 UTC
"cgalpngtest_nef3_broken" time elapsed: 00:00:00

    
645/1315 Testing: opencsgtest_nef3_broken
645/1315 Test: opencsgtest_nef3_broken
Command: "/gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/test_cmdline_tool.py" "--comparator=" "-c" "/gnu/store/vlix7fclb7ifjgmxgpwr1pvraff89w7b-imagemagick-6.9.11-48/bin/convert" "-s" "png" "-t" "opencsgtest" "-f" "nef3_broken" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad" "-o"
Directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests
"opencsgtest_nef3_broken" start time: Mar 05 21:23 UTC
Output:
----------------------------------------------------------
nef3_broken
run_test() cmdline: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad -o /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/opencsgtest/nef3_broken-actual.png
using font directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/ttf
stderr output: CGAL warning: check violation!
Expression : false
File       : /gnu/store/dsajl7cc1mm4sfl6kzv9yqn8vccanc0l-cgal-5.2/include/CGAL/Nef_3/SNC_io_parser.h
Line       : 1480
Explanation: SNC_io_parser::read: error in edge line
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html

Error: openscad failed with return code -11

Test time =   0.05 sec
----------------------------------------------------------
Test Failed.
"opencsgtest_nef3_broken" end time: Mar 05 21:23 UTC
"opencsgtest_nef3_broken" time elapsed: 00:00:00

835/1315 Testing: csgpngtest_nef3_broken
835/1315 Test: csgpngtest_nef3_broken
Command: "/gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/test_cmdline_tool.py" "--comparator=" "-c" "/gnu/store/vlix7fclb7ifjgmxgpwr1pvraff89w7b-imagemagick-6.9.11-48/bin/convert" "-s" "png" "-e" "cgalpngtest" "-t" "csgpngtest" "-f" "nef3_broken" "/gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/export_import_pngtest.py" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad" "--openscad=/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad" "--format=csg" "--render"
Directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests
"csgpngtest_nef3_broken" start time: Mar 05 21:24 UTC
Output:
----------------------------------------------------------
nef3_broken
run_test() cmdline: /gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3 /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/export_import_pngtest.py /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad --openscad=/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad --format=csg --render /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/csgpngtest/nef3_broken-actual.png
using font directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/ttf
stderr output: WARNING: variable timestamp not specified as parameter in file nef3_broken.scad.csg, line 1
CGAL warning: check violation!
Expression : false
File       : /gnu/store/dsajl7cc1mm4sfl6kzv9yqn8vccanc0l-cgal-5.2/include/CGAL/Nef_3/SNC_io_parser.h
Line       : 1480
Explanation: SNC_io_parser::read: error in edge line
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html
Running OpenSCAD #1:
/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad -o /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/scad/nef3/nef3_broken.scad.csg --render=cgal
Running OpenSCAD #2:
/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/scad/nef3/nef3_broken.scad.csg -o /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/csgpngtest/nef3_broken-actual.png --render

stdout output: ('OpenSCAD #2 failed with return code -11',)
export_import_pngtest args: ['/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/export_import_pngtest.py', '/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad', '--openscad=/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad', '--format=csg', '--render', '/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/csgpngtest/nef3_broken-actual.png']
exiting export_import_pngtest.py with failure

Error: python3 failed with return code 1

Test time =   0.11 sec
----------------------------------------------------------
Test Failed.
"csgpngtest_nef3_broken" end time: Mar 05 21:24 UTC
"csgpngtest_nef3_broken" time elapsed: 00:00:00


1032/1315 Testing: throwntogethertest_nef3_broken
1032/1315 Test: throwntogethertest_nef3_broken
Command: "/gnu/store/rz42ba0my9vrgbkjpkzr2drmnjk5ah50-python-3.8.2/bin/python3" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/test_cmdline_tool.py" "--comparator=" "-c" "/gnu/store/vlix7fclb7ifjgmxgpwr1pvraff89w7b-imagemagick-6.9.11-48/bin/convert" "-s" "png" "-t" "throwntogethertest" "-f" "nef3_broken" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad" "/tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad" "--preview=throwntogether" "-o"
Directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests
"throwntogethertest_nef3_broken" start time: Mar 05 21:25 UTC
Output:
----------------------------------------------------------
nef3_broken
run_test() cmdline: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../openscad /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/../testdata/scad/nef3/nef3_broken.scad --preview=throwntogether -o /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/tests/output/throwntogethertest/nef3_broken-actual.png
using font directory: /tmp/guix-build-openscad-2021.01.drv-0/openscad-2021.01/testdata/ttf
stderr output: CGAL warning: check violation!
Expression : false
File       : /gnu/store/dsajl7cc1mm4sfl6kzv9yqn8vccanc0l-cgal-5.2/include/CGAL/Nef_3/SNC_io_parser.h
Line       : 1480
Explanation: SNC_io_parser::read: error in edge line
Refer to the bug-reporting instructions at https://www.cgal.org/bug_report.html

Error: openscad failed with return code -11

Test time =   0.05 sec
----------------------------------------------------------
Test Failed.
"throwntogethertest_nef3_broken" end time: Mar 05 21:25 UTC
"throwntogethertest_nef3_broken" time elapsed: 00:00:00

See full log files:
openscad-test-logs.tar.gz

I am not sure if CGAL or openscad is wrong here, reporting against CGAL also shortly.

Thank you

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[t-paul]

Ok, closing this, as far as I can tell, there's not much else than hope the issue is fixed in CGAL.

[t-paul]

@thehans found a solution via #3936, that would have been a nice pointer from the CGAL side.