Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-tab feature in TabManager class #2955

Open
wants to merge 36 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@RomitKumar
Copy link
Contributor

commented May 26, 2019

The commit currently has basic gui implemented. Editing features like commenting, etc needs to be handled for each separate tab.
This commit will fail the checker since support for legacy editor is removed.

RomitKumar added some commits May 26, 2019

Implement multi-tab feature in TabManager class
The commit currently has basic gui implemented. Editing features like commenting, etc needs to be handled for each separate tab.
This commit will fail the checker since support for legacy editor is removed.
Integrate support for legacy and scintilla editor along
Add a gui option for mulit-tab editor in Preferences. Users can switch among various editors

@RomitKumar RomitKumar force-pushed the RomitKumar:multi-tab branch from 18c11bf to 6bc13c5 Jun 3, 2019

RomitKumar added some commits Jun 4, 2019

Extended Find, Find and Replace behaviour for multi-tab
Besides, changed the function signature of stopAnimation since index of changed tab is not required.
Removed support for single file QScintilla Editor
The application now has only multi-tab QScintilla Editor. When single tab is present, the tabs are not visible, effectively giving the feeling of single-tab editor.
Add the feature of New Tab
It opens a file in New Tab. Save and Save As is working fine. The tab and window title shows the name of current file. Tab Tool tip contains path of file. File name is displayed on undocking widgets.

RomitKumar added some commits Jun 11, 2019

Changed behaviour of option in file menu
Arragned items in File menu. Updated behaviour of Open, Open Tab.
Cleanup of Code
This commit includes removing unhelpful comment statements, correcting the implementation of Reload, remove mdi checkbox from Preferences/Advanced, discarded redundant functions openFile() and setFileName() from MainWindows, prevent double emmission of currentChanged signal for first tab.

RomitKumar added some commits Jun 17, 2019

Tab tool bar hidden for single tab
Also corrected opening of file when given in command line argument
Corrected implementation of opening of file in empty editor tab
Previously, empty scad file does not set window title and designs were loaded twice for scad files

@RomitKumar RomitKumar force-pushed the RomitKumar:multi-tab branch from 65dc9e0 to a99d689 Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.