Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update working of No option in reload #3022

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@RomitKumar
Copy link
Contributor

commented Jul 31, 2019

The reload confirmation dialog box counter-intuitively turns off automatic reload on choosing No option. The pr removes this behavior and No option simply does not reload the file.

Copy link
Member

left a comment

This check is done both for auto-reload and manual reload, so for "Never" to work, we'd need a preference setting for that as well.

@RomitKumar

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

Are you suggesting to add different preference setting(checkbox) for auto-reload and manual reload? The auto-reload or manual reload works only if the corresponding checkbox is ticked.
My intended functionality is that "Never" option simply does the work of "No" while "No" doesn't do anything.

@kintel

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

I'm not sure what the best solution is. Right now it's a bit confusing since "Never" won't work for manual reloads. Getting GUI like this right is tricky.

@RomitKumar

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

"Never" should only stop auto-reload. It can be strange when user triggers manual reload, and the file is not reloaded because of some preference setting set sometime in the past. I guess any manual reload should ideally reload the file irrespective of preference setting.
Yeah, the name "Never" can be confusing. I guess we can replace that with "No and stop auto-reload" or something more concise.

@MichaelAtOz

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

OP "counter-intuitively turns off automatic reload on choosing No option."
So how about just not doing that. Leave it to the user to sort out preferences.
Mostly auto-reload is used with external editors, it would be rare to want to change that too often.
or
Maybe "Disable auto-reload" instead of "Never". But I prefer the do nothing option.

@RomitKumar RomitKumar changed the title Added never option to reload Update working of No option in reload Sep 9, 2019
@kintel
kintel approved these changes Sep 11, 2019
@kintel kintel merged commit b5a7c5f into openscad:master Sep 11, 2019
5 checks passed
5 checks passed
ci/circleci: openscad-appimage-64bit Your tests passed on CircleCI!
Details
ci/circleci: openscad-mxe-32bit Your tests passed on CircleCI!
Details
ci/circleci: openscad-mxe-64bit Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.