Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file bounds check to comment parser, issue #4043 #4044

Merged
merged 1 commit into from Jan 9, 2022

Conversation

eldstal
Copy link
Contributor

@eldstal eldstal commented Jan 9, 2022

This is a security fix, mitigating an out-of-bounds read as outlined in issue #4043

Copy link
Member

@t-paul t-paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing that issue, much appreciated.

@t-paul t-paul merged commit 78a82cf into openscad:master Jan 9, 2022
12 checks passed
@eldstal eldstal deleted the oobr_comment branch January 10, 2022 12:38
t-paul added a commit that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants