Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plume plot #139

Merged
merged 14 commits into from Feb 10, 2021
Merged

Plume plot #139

merged 14 commits into from Feb 10, 2021

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jan 18, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm/scmdata/issues/YY>`_)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@znicholls znicholls marked this pull request as ready for review January 19, 2021 04:54
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #139 (565dfd3) into master (6012b2b) will increase coverage by 0.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   93.77%   93.78%   +0.01%     
==========================================
  Files          15       15              
  Lines        1527     1610      +83     
  Branches      303      326      +23     
==========================================
+ Hits         1432     1510      +78     
- Misses         77       79       +2     
- Partials       18       21       +3     
Impacted Files Coverage Δ
src/scmdata/plotting.py 94.56% <93.90%> (-5.44%) ⬇️
src/scmdata/filters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6012b2b...565dfd3. Read the comment docs.

Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a test which runs (but doesn't necessarily check the resulting plot) might be useful if the seaborn/matplotlib api's change

@lewisjared
Copy link
Collaborator

I was playing with this yesterday, but I had trouble getting it to work. It assumes that you have already calculated the quantiles, no? Can you add an example?

@znicholls
Copy link
Collaborator Author

It assumes that you have already calculated the quantiles, no

Yep

Can you add an example

On top of the notebook?

Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. That fixed a few things that confused me when I had a play with plumeplot

@lewisjared lewisjared merged commit 6fea878 into master Feb 10, 2021
@lewisjared lewisjared deleted the plume-plot branch January 3, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants