New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plume plot #139
Plume plot #139
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 93.77% 93.78% +0.01%
==========================================
Files 15 15
Lines 1527 1610 +83
Branches 303 326 +23
==========================================
+ Hits 1432 1510 +78
- Misses 77 79 +2
- Partials 18 21 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a test which runs (but doesn't necessarily check the resulting plot) might be useful if the seaborn/matplotlib api's change
I was playing with this yesterday, but I had trouble getting it to work. It assumes that you have already calculated the quantiles, no? Can you add an example? |
Yep
On top of the notebook? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement. That fixed a few things that confused me when I had a play with plumeplot
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: