Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MouseTracker preProcessEvent on keydown, keyup, keypress, focus, blur Events #1951

Merged
merged 9 commits into from Mar 12, 2021

Conversation

msalsbery
Copy link
Member

@msalsbery msalsbery commented Mar 10, 2021

Also:

Added preventDefault option to MouseTracker.contextMenuHandler and Viewer 'canvas-contextmenu' event objects for easy disabling of context menu on viewers

Removed a bit more IE<11 code

@msalsbery msalsbery added this to the 2.5.0 milestone Mar 10, 2021
@msalsbery msalsbery self-assigned this Mar 10, 2021
@msalsbery
Copy link
Member Author

@iangilman

This one's ready when you are...

This mainly just adds the often-neglected keyboard events to the preProcessEvent system so all raw DOM events are covered

@msalsbery msalsbery linked an issue Mar 11, 2021 that may be closed by this pull request
Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I took the liberty of moving the "IE < 11" tag for this PR up to the changelog item at the top.

@iangilman iangilman merged commit dc75398 into master Mar 12, 2021
@iangilman iangilman deleted the ms-mousetracker branch March 12, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy Internet Explorer Support?
2 participants