Button Image Alignment Fix (#30) #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New commit... Made the Button divs tab stops so keyboard navigation works |
Wrapped the images in a single div and used that as the content of a button element.
Removed commented and leftover code
|
New commits... A better fix. Wrapped the images in a single div and used that as the content of a button element. Pretty much the same result as last commit, but as a button element any accessibility features will be there too. Removed commented and leftover code |
|
Tested on IE 11, Firefox 25, Chrome 31, Opera 18 (Windows 7) |
|
Beautiful! Thank you for sorting this out in a way that maintains accessibility. |
iangilman
added a commit
that referenced
this pull request
Dec 9, 2013
Button Image Alignment Fix (#30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Button class button element for consistent rendering across browsers.
Fix for #30.