Support tile-less IIIF as per LegacyTileSource: Fix #737 #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Beautiful, thank you! |
iangilman
added a commit
that referenced
this pull request
Jan 11, 2016
Support tile-less IIIF as per LegacyTileSource: Fix #737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did experiment with a version that removed any duplication of code from LegacyTileSource - but that made IIIFTileSource depend on the existence and implementation of LegacyTileSource, which seemed less preferable than a dozen or so lines of borrowed logic. This PR has no dependency on LegacyTileSource.
The same legacy image pyramid can be used as a test and demo for LegacyTileSource, so I have added two new tests to formats.js.
The leaves image was created by my partner and my daughter; there are no rights issues.