Extract excludes into a file, fix the link checker by adding http://site.icu-project.org/.#1189
Conversation
|
✅ Gradle Wrapper Validation success 15ad48d58c1837a11f7522e3ee4d1da0ec322927 |
Signed-off-by: dblock <dblock@dblock.org>
|
✅ DCO Check Passed 15ad48d58c1837a11f7522e3ee4d1da0ec322927 |
|
✅ Gradle Wrapper Validation success b0fac08 |
|
✅ DCO Check Passed b0fac08 |
Signed-off-by: dblock <dblock@dblock.org>
|
✅ DCO Check Passed e02e7cc |
|
✅ Gradle Wrapper Validation success e02e7cc |
|
✅ DCO Check Passed e21844383594c37481cdbca320d981bd9b3544a4 |
|
✅ Gradle Wrapper Validation success e21844383594c37481cdbca320d981bd9b3544a4 |
|
✅ Gradle Precommit success 15ad48d58c1837a11f7522e3ee4d1da0ec322927 |
|
✅ Gradle Precommit success b0fac08 |
dblock
changed the title
|
✅ Gradle Precommit success e02e7cc |
|
✅ Gradle Wrapper Validation success 6e813f92fc6528262bcba50401b9d74dc334c825 |
|
✅ DCO Check Passed 6e813f92fc6528262bcba50401b9d74dc334c825 |
|
✅ Gradle Wrapper Validation success ddafcf740f83878aeb4593a1b3f6fa751a70d6b6 |
|
✅ DCO Check Passed ddafcf740f83878aeb4593a1b3f6fa751a70d6b6 |
|
✅ Gradle Precommit success e21844383594c37481cdbca320d981bd9b3544a4 |
|
✅ Gradle Precommit success 6e813f92fc6528262bcba50401b9d74dc334c825 |
|
✅ Gradle Wrapper Validation success 733c4363fccaf268b042a3c348aaef16fe043d28 |
|
✅ DCO Check Passed 733c4363fccaf268b042a3c348aaef16fe043d28 |
Signed-off-by: dblock <dblock@dblock.org>
|
✅ Gradle Wrapper Validation success 708ca10 |
|
✅ Gradle Wrapper Validation success 23957639e910475315ed85cc585930b3791a5282 |
.lycheeexclude-mail
Outdated
There was a problem hiding this comment.
--exclude-mail is just a flag to exclude checking mailing addresses. The "**/*.html" "**/*.md" "**/*.txt" "**/*.json" are the type of files that need to be checked. The file can be renamed to reflect that.
|
✅ DCO Check Passed 23957639e910475315ed85cc585930b3791a5282 |
|
✅ Gradle Wrapper Validation success 453d64ceeb25af15d7cf2ced912e05657169002d |
|
✅ DCO Check Passed 453d64ceeb25af15d7cf2ced912e05657169002d |
|
Not sure what lychee is but is this addressing the ongoing linkchecker failure? |
|
✅ Gradle Precommit success 23957639e910475315ed85cc585930b3791a5282 |
|
✅ Gradle Precommit success 453d64ceeb25af15d7cf2ced912e05657169002d |
It's the link checker. One of the websites, http://site.icu-project.org/, has gone MIA, so it started failing. This addresses that + makes it easier to address it in the future by extracting the configuration into config files. |
|
start gradle check |
|
✅ Gradle Check success 453d64ceeb25af15d7cf2ced912e05657169002d |
Signed-off-by: dblock <dblock@dblock.org>
dblock
changed the title
dblock
changed the title
|
start gradle check |
|
✅ DCO Check Passed e3382e6 |
|
Can I please have another CR @VachaShah after fixing my epic fail of |
|
✅ Gradle Wrapper Validation success e3382e6 |
|
✅ Gradle Precommit success e3382e6 |
6 participants
Signed-off-by: dblock dblock@dblock.org
Description
--excludeconfig into a file.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.