-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions on how to start OpenSearch in debug mode #689
Update instructions on how to start OpenSearch in debug mode #689
Conversation
✅ Gradle Wrapper Validation success 269cece626a227a7c4a0541a665b35916a0a2aab |
✅ DCO Check Passed 269cece626a227a7c4a0541a665b35916a0a2aab |
✅ Gradle Precommit success 269cece626a227a7c4a0541a665b35916a0a2aab |
We removed line breaks in a previous commit. Why are we re-adding those for .md files? With line breaks it's just very hard to read multiline sentence diffs when someone goes and adds words, everything gets re-formated across many lines and we don't know what changed anymore. And markdown doesn't use line breaks. |
Is that the best practice? I think it's better to wrap the long lines than doing horizontal scrolling while editing (I know I can soft-wrap it in my editor). What do you mean by "markdown doesn't use line breaks" ? For instance, here is a style guide from Google. |
I can't speak for Google or the best practice. I think this one is YMMV. On Markdown doesn't use line breaks: whether you include a line break in your markdown or not the rendered result is the same, unless you use 2 line breaks. Hear me out then decide whether you want me to merge as is or not. Example old text
replaced with
2-line change, but Instead
So much easier to grok. |
start gradle check |
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
✅ DCO Check Passed 1b7a4db |
✅ Gradle Wrapper Validation success 1b7a4db |
✅ Gradle Check success 269cece626a227a7c4a0541a665b35916a0a2aab |
✅ Gradle Precommit success 1b7a4db |
@dblock reverted the line break change. |
start gradle check |
Description
Updated instructions on how to start OpenSearch in debug mode in IntelliJ IDEA.
Also, fixed some minor typos and added line breaks.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com