Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sending Events to multiple pipelines does not duplicate Events #1886

Closed
dlvenable opened this issue Oct 5, 2022 · 0 comments · Fixed by #1897
Closed

[BUG] Sending Events to multiple pipelines does not duplicate Events #1886

dlvenable opened this issue Oct 5, 2022 · 0 comments · Fixed by #1897
Labels
bug Something isn't working
Milestone

Comments

@dlvenable
Copy link
Member

Describe the bug

Data Prepper supports creating a pipeline which uses the pipeline sink to send events to multiple downstream pipelines. However, the Event is not being copied. Thus, the same Event object is passed into multiple threads. This produces unexpected behavior.

To Reproduce

Create a pipeline which modifies an Event in a downstream pipeline.

Expected behavior

Modifying an Event in one pipeline should not modify it in others. The PipelineConnector should duplicate the Events.

Additional context

The Event model contains metadata, making it hard to "copy" an event. We solved this in peer-forwarder with a quick fix which is can be seen in this PR. However, this approach is not highly extensible since it requires a lot of knowledge duplicated throughout the code.

@dlvenable dlvenable added the bug Something isn't working label Oct 5, 2022
@dlvenable dlvenable added this to the v2.1 milestone Oct 5, 2022
@dlvenable dlvenable modified the milestones: v2.1, v2.0.1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant