[RPM M1] Add rpm assemble/bundle code for opensearch using rpmbuild

[peterzhuamazon]

Description

Add rpm assemble/bundle code for opensearch using rpmbuild.
Adding rpm specific block so that cpio is used during extraction, and rpmbuild is used during build.
A specific opensearch spec file is provided, dashboards one will be committed in another PR.

Issues Resolved

Part of #1545

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (c8cf15e) to head (f010bb6).
Report is 2125 commits behind head on main.

Files with missing lines	Patch %	Lines
src/assemble_workflow/bundle_rpm.py	83.67%	8 Missing ⚠️
src/assemble_workflow/dist.py	75.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1726      +/-   ##
============================================
- Coverage     94.76%   94.59%   -0.17%     
- Complexity       14       17       +3     
============================================
  Files           168      170       +2     
  Lines          3512     3592      +80     
  Branches         26       26              
============================================
+ Hits           3328     3398      +70     
- Misses          181      191      +10     
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peterzhuamazon]

Hi @dblock please review the code and I will add test cases later.

Thanks.

[dblock]

Needs passing tests and documentation updates.

[dblock]

The cd worries me. Can we merge without that?

[peterzhuamazon]

@spotrh would you mind checking the spec file in this PR?

Thanks.

Note: as of now we are using bundled JDK per #1682 (comment)

And we are also thinking about using Adopt per community suggestions: opensearch-project/OpenSearch#2312 (comment)

[zelinh]

Block this PR for now until Spot review the spec files.

[spotrh]

Looks very good to me. I don't understand the tests well enough here to be sure, but I don't think there is any CI integration to confirm that the RPM was properly generated (or generated at all). Not a blocker for this, but probably something you want to do.

[peterzhuamazon]

Looks very good to me. I don't understand the tests well enough here to be sure, but I don't think there is any CI integration to confirm that the RPM was properly generated (or generated at all). Not a blocker for this, but probably something you want to do.

Yes @spotrh we have plans to add tests and verifications here: #27
See milestone 5 / 6 about the steps we plan to do.

Thanks.

@spotrh has approved the PR now.

[zelinh]

Block this one from merging since we haven't generated the artifacts candidates for 1.3.0 release.

1.3.0 is released we can resume this now.