Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced existing API generator to use the OpenAPI spec as the input format #412

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

saimedhi
Copy link
Collaborator

Description

Enhanced existing API generator to use the OpenAPI spec as the input format

Issues Resolved

Closes #348

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi saimedhi changed the title Python client generator Enhanced existing API generator to use the OpenAPI spec as the input format Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #412 (f3ddc99) into main (f1b5706) will decrease coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   72.12%   71.66%   -0.46%     
==========================================
  Files          77       77              
  Lines        7190     7190              
==========================================
- Hits         5186     5153      -33     
- Misses       2004     2037      +33     

see 10 files with indirect coverage changes

@saimedhi
Copy link
Collaborator Author

@VachaShah, @harshavamsi, @dblock

This PR is ready for review. And I notice that 1 Integration test is exhibiting flaky behavior, it is also failing for other PRs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! How do I use this? Can we please document at least some of it as part of the developer guide in this PR?

Please do open issues for flaky tests if there aren't any.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: saimedhi <saimedhi@amazon.com>
@dblock
Copy link
Member

dblock commented Jun 26, 2023

@harshavamsi you're good with this?

@VachaShah VachaShah merged commit bc6a50b into opensearch-project:main Jun 27, 2023
44 of 45 checks passed
@saimedhi saimedhi deleted the Python-Client-Generator branch October 4, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhance the existing code generator to use the OpenAPI spec as the input format
3 participants