Parse raw_data on error only if the Content-Type is application/json. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
reviewed
Nov 26, 2021
VijayanB
reviewed
Nov 26, 2021
added 3 commits
December 20, 2021 13:14
Some opensearch REST APIs will return a Content-Type of text/plain for certain
status codes which will trigger logging when the response is not parsable as
json. Checking the content-type first avoids this error.
This frequently happens with 401s, which occurs when we rotate user keys.
The input that triggers this behavior can be triggered with `curl`:
```
$ curl -k -u"admin:wrong" -w"\n%{http_code}\n%{content_type}\n" https://localhost:9200/_cluster/health
Unauthorized
401
text/plain; charset=UTF-8
```
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
|
Rebased and signed the commits. Fixed formatting error http_urllib3.py. PTAL |
axeoman
reviewed
Dec 21, 2021
added 3 commits
December 21, 2021 09:41
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
Signed-off-by: Trevor McCulloch <trevor.mcculloch@benchling.com>
axeoman
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some opensearch REST APIs will return a Content-Type of text/plain for certain
status codes which will trigger logging when the response is not parsable as
json. Checking the content-type first avoids this error.
This frequently happens with 401s, which occurs when we rotate user keys.
The input that triggers this behavior can be triggered with
curl:Issues Resolved
#92
Check List
Signed-off-by: Trevor McCulloch trevor.mcculloch@benchling.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.