Fix some scoping text #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey duglin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
The OSBAPI website seems to be down and that is making the build fail. Should we move images to this repo? |
|
LGTM |
|
we need to switch our OSB API URLs to be http instead of https. |
|
Rebased and ready for another round of reviews |
|
LGTM |
1 similar comment
|
LGTM |
- plan_id are globally unique, not scoped to the service - I also fixed it so that we don't place requirements on the usage of IDs since that isn't necessary. Only the creation of the ID should state things like "its globally unique" or must be non-empty string. The users of that ID can't control that aspect of it. However, we can control where the ID comes from so I added text to say things like "it MUST be the ID of a previously provisioned service". Signed-off-by: Doug Davis <dug@us.ibm.com>
|
rebased and ready for reviews |
|
LGTM |
1 similar comment
|
LGTM |
|
2 more reviews needed |
|
LGTM |
|
one more review needed |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since that isn't necessary. Only the creation of the ID should state
things like "its globally unique" or "must be non-empty string".
The users of that ID can't control
that aspect of it. However, we can control where the ID comes from so
I added text to say things like "it MUST be the ID of a previously
provisioned service".
Signed-off-by: Doug Davis dug@us.ibm.com