Skip to content

Conversation

@kaldesai
Copy link
Contributor

@kaldesai kaldesai commented Dec 4, 2023

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165

Doc previews & Description:
Please check the following sections:

The overview conveys that this URL covers information that is DP and TP and the respective section mentions that they are TP or DP respectively.

@netlify
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit ac99c4a
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/656ed951405c1b0008200ad4
😎 Deploy Preview https://deploy-preview-104--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kaldesai
Copy link
Contributor Author

kaldesai commented Dec 4, 2023

@mgencur, I have incorporated all of your suggestions here in this new PR. Can you please take a look and verify once? (Closed the previous PR)

If you need assistance with OpenShift Serverless - Developer Preview releases, please reach out on the following mailing list, where the Red Hat Development Team will be happy to assist you based on the availability and work schedules: serverless-interest@redhat.com
====
{serverlessproductname} provides information about additional, advanced use cases and integrations that are possible using OpenShift Container Platform and OpenShift Serverless, but are for technology and development purposes and are not officially supported by Red Hat.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think OpenShift Container Platform should be replaced with some variable { ... } and OpenShift Serverless should be replaced with {serverlessproductname}.

The rest of this PR looks good. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I have added the attribute for the OpenShift Container Platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur Can you please merge this PR now if everything is fine?

@mgencur
Copy link
Contributor

mgencur commented Dec 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2023
@mgencur mgencur merged commit 3d09092 into openshift-knative:master Dec 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaldesai, mgencur

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaldesai kaldesai changed the title [WIP] New & Updated PR for SRVLOGIC-165-New-midstream: Add a TP and DP notes and change the title to Technology and Developer Preview releases New & Updated PR for SRVLOGIC-165-New-midstream: Add a TP and DP notes and change the title to Technology and Developer Preview releases Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants