-
Notifications
You must be signed in to change notification settings - Fork 28
New & Updated PR for SRVLOGIC-165-New-midstream: Add a TP and DP notes and change the title to Technology and Developer Preview releases #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mgencur, I have incorporated all of your suggestions here in this new PR. Can you please take a look and verify once? (Closed the previous PR) |
modules/ROOT/pages/index.adoc
Outdated
| If you need assistance with OpenShift Serverless - Developer Preview releases, please reach out on the following mailing list, where the Red Hat Development Team will be happy to assist you based on the availability and work schedules: serverless-interest@redhat.com | ||
| ==== | ||
| {serverlessproductname} provides information about additional, advanced use cases and integrations that are possible using OpenShift Container Platform and OpenShift Serverless, but are for technology and development purposes and are not officially supported by Red Hat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think OpenShift Container Platform should be replaced with some variable { ... } and OpenShift Serverless should be replaced with {serverlessproductname}.
The rest of this PR looks good. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I have added the attribute for the OpenShift Container Platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgencur Can you please merge this PR now if everything is fine?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaldesai, mgencur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165
Doc previews & Description:
Please check the following sections:
The overview conveys that this URL covers information that is DP and TP and the respective section mentions that they are TP or DP respectively.
Changed the title of the doc: OpenShift Serverless - Technology and Developer Preview Releases
Overview (The overview covers the note about both TP and DP)
About OpenShift Serverless Logic (Added a TP note)
Setup OpenShift Serverless with OpenShift Service Mesh (Added a TP note)
About buildpacks for OpenShift Serverless Functions (Added a DP note)
Use Serving with OpenShift ingress sharding (Added a DP note)