From 729b111e899fab5505f8937914fe163ae41b2689 Mon Sep 17 00:00:00 2001 From: OpenShift Cherrypick Robot Date: Tue, 10 May 2022 07:24:01 -0700 Subject: [PATCH] adding 408 - Request Timeout to list of retryable status codes (#2160) (#256) Signed-off-by: Matthias Wessendorf Co-authored-by: Matthias Wessendorf --- .../dispatcher/impl/http/WebClientCloudEventSender.java | 1 + .../dispatcher/impl/http/WebClientCloudEventSenderTest.java | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java b/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java index 95bf3e3c62..448931f07c 100644 --- a/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java +++ b/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java @@ -201,6 +201,7 @@ static boolean isRetryableStatusCode(final int statusCode) { // From https://github.com/knative/specs/blob/c348f501de9eb998b4fd010c54d9127033ee41be/specs/eventing/data-plane.md#event-acknowledgement-and-delivery-retry return statusCode >= 500 || // Generic error statusCode == 404 || // Endpoint does not exist + statusCode == 408 || // Request Timeout statusCode == 409 || // Conflict / Processing in progress statusCode == 429; // Too Many Requests / Overloaded } diff --git a/data-plane/dispatcher/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSenderTest.java b/data-plane/dispatcher/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSenderTest.java index ba7a018675..9c45a7d5f6 100644 --- a/data-plane/dispatcher/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSenderTest.java +++ b/data-plane/dispatcher/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSenderTest.java @@ -77,7 +77,7 @@ public static Stream nonRetryableStatusCodes() { return Stream.concat( Stream.concat( IntStream.range(200, 404).boxed(), - IntStream.range(405, 409).boxed() + IntStream.range(405, 408).boxed() ), Stream.concat( IntStream.range(410, 429).boxed(), @@ -89,7 +89,7 @@ public static Stream nonRetryableStatusCodes() { public static Stream retryableStatusCodes() { return Stream.concat( IntStream.range(500, 600).boxed(), - IntStream.of(404, 409, 429).boxed() + IntStream.of(404, 408, 409, 429).boxed() ); } }