Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding python module details to readme #243

Merged
merged 1 commit into from Mar 24, 2020

Conversation

rlopez133
Copy link
Collaborator

@rlopez133 rlopez133 commented Mar 24, 2020

Description

Adding README details to the python modules required for using the Ansible playbook.

Fixes #233

Type of change

Please select the appropiate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not being merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

@rlopez133 rlopez133 requested a review from abays March 24, 2020 15:03
@rlopez133 rlopez133 self-assigned this Mar 24, 2020
@rlopez133 rlopez133 requested review from e-minguez and removed request for slintes and ffromani March 24, 2020 15:03
Copy link
Member

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions

ansible-ipi-install/README.md Outdated Show resolved Hide resolved
ansible-ipi-install/README.md Outdated Show resolved Hide resolved
ansible-ipi-install/README.md Outdated Show resolved Hide resolved
ansible-ipi-install/README.md Outdated Show resolved Hide resolved
@e-minguez
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@rlopez133 rlopez133 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4604fd9 into openshift-kni:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation doesn't mention which python modules needed on localhost
4 participants