Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to open the console URL in browser #8

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@cblecker
Copy link
Contributor

commented Sep 7, 2019

No description provided.

@cblecker cblecker force-pushed the cblecker:console-open branch 2 times, most recently from c62c438 to 8cd19a5 Sep 7, 2019

@jhernand
Copy link
Collaborator

left a comment

Looks good. I only have some minor comments. Address them and I will merge.

cmd/ocm/cluster/login/login.go Outdated Show resolved Hide resolved
cmd/ocm/cluster/login/login.go Outdated Show resolved Hide resolved
cmd/ocm/cluster/login/login.go Outdated Show resolved Hide resolved
cmd/ocm/cluster/login/login.go Outdated Show resolved Hide resolved

@cblecker cblecker force-pushed the cblecker:console-open branch from 8cd19a5 to 78ad876 Sep 9, 2019

@cblecker

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@jhernand Feedback addressed! Thanks!

@jhernand
Copy link
Collaborator

left a comment

Looks good. Thanks @cblecker.

@jhernand jhernand merged commit de6f626 into openshift-online:master Sep 9, 2019

1 check passed

ci.ext.devshift.net PR build
Details

@cblecker cblecker deleted the cblecker:console-open branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.