Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go modules #51

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@jhernand
Copy link
Collaborator

commented Aug 8, 2019

This patch changes the project so that it builds using Go modules.

Use Go modules
This patch changes the project so that it builds using Go modules.

Signed-off-by: Juan Hernandez <jhernand@redhat.com>

@jhernand jhernand requested a review from ALimaRedHat Aug 8, 2019

@ALimaRedHat
Copy link
Collaborator

left a comment

@jhernand Don't know much about go modules but it looks good to me.

@cblecker
Copy link
Contributor

left a comment

one comment, otherwise lgtm

@@ -15,26 +15,26 @@
#

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 9, 2019

Contributor

Adding in a export GO111MODULE=on to the Makefile may be advisable, so that even if this this repo is in the GOPATH, go will use the go.mod file.

This comment has been minimized.

Copy link
@jhernand

jhernand Aug 11, 2019

Author Collaborator

Looks reasonable to me. Can you send a pull request to add that?

@jhernand jhernand merged commit be3cb86 into openshift-online:master Aug 11, 2019

1 check passed

ci.ext.devshift.net PR build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.