Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a config file for golangci-lint #54

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@cblecker
Copy link
Contributor

commented Aug 11, 2019

Use a config files for golangci-lint instead of using command line flags in make. This is effectively a noop as I've just copied the same flags that are currently in the Makefile into the config file.

@cblecker cblecker force-pushed the cblecker:lint-config branch from 1daaf68 to 3449a2c Aug 11, 2019

@jhernand
Copy link
Collaborator

left a comment

Looks good to me. Thanks @cblecker.

@jhernand jhernand merged commit d316716 into openshift-online:master Aug 11, 2019

1 check passed

ci.ext.devshift.net PR build
Details

@cblecker cblecker deleted the cblecker:lint-config branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.