This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Add support for bash completions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernand
reviewed
May 8, 2019
cmd/uhc/main.go
Outdated
| @@ -63,6 +63,7 @@ func init() { | |||
| root.AddCommand(token.Cmd) | |||
| root.AddCommand(version.Cmd) | |||
| root.AddCommand(cluster.Cmd) | |||
| root.AddCommand(completionCmd) | |||
There was a problem hiding this comment.
All the other commands in the CLI live in their own package. Can you do the same for this one? Create a new cmd/uhc/completion directory and put the code there. Then this will be root.AddCommand(completion.Cmd).
There was a problem hiding this comment.
This isn't easily done, as I need to refer back to the top-level command (root): https://github.com/openshift-online/uhc-cli/pull/9/files#diff-7e01ad4f5f72c98103727d222dba6a64R42
There was a problem hiding this comment.
You can do cmd.Root()....
There was a problem hiding this comment.
Thanks for the tip! Fixed.
cmd/uhc/completion.go
Outdated
| @@ -0,0 +1,47 @@ | |||
| /* | |||
| Copyright (c) 2018 Red Hat, Inc. | |||
|
Thanks @cblecker, looks good, I am merging. |
|
@cblecker your change is included in release 0.1.11. |
|
Thanks @jhernand! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.