Skip to content

OWNERS Cleanup#754

Open
apahim wants to merge 1 commit into
openshift:mainfrom
apahim:cleanup-apahim
Open

OWNERS Cleanup#754
apahim wants to merge 1 commit into
openshift:mainfrom
apahim:cleanup-apahim

Conversation

@apahim

@apahim apahim commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated code ownership and approval assignments
    • Modified team alias groupings for code review processes

Signed-off-by: Amador Pahim <apahim@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 51411adb-da62-497c-9bd7-b48571f801df

📥 Commits

Reviewing files that changed from the base of the PR and between f5b3118 and ec69a1c.

📒 Files selected for processing (2)
  • OWNERS
  • OWNERS_ALIASES
💤 Files with no reviewable changes (2)
  • OWNERS_ALIASES
  • OWNERS

Walkthrough

This PR updates project ownership configuration by removing a person from the OWNERS file and updating team alias mappings in OWNERS_ALIASES. The apahim user is removed from both approvers and reviewers, and a new srep-architects team replaces the sre-group-leads alias.

Changes

Ownership and team alias updates

Layer / File(s) Summary
Remove person from OWNERS
OWNERS
apahim is removed from both approvers (line 2–3) and reviewers (line 15–16) lists.
Update team aliases
OWNERS_ALIASES
The sre-group-leads alias is removed and replaced with srep-architects containing jharrington22 and cblecker (line 88–91).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OWNERS Cleanup' accurately reflects the main changes: removal of apahim from OWNERS and restructuring of OWNERS_ALIASES.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies OWNERS and OWNERS_ALIASES config files, not test code. Check for Ginkgo test names is not applicable; repo uses standard Go testing.
Test Structure And Quality ✅ Passed PR only modifies OWNERS and OWNERS_ALIASES configuration files; no Ginkgo test code is present in changes, making the test quality check not applicable.
Microshift Test Compatibility ✅ Passed PR modifies only OWNERS configuration files with no Ginkgo e2e test additions, making the MicroShift test compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only OWNERS configuration changes; no new Ginkgo e2e tests added. SNO compatibility check not applicable to non-test files.
Topology-Aware Scheduling Compatibility ✅ Passed Deployment manifests use required pod anti-affinity with maxUnavailable: 1 (safe), target infra nodes only, include proper tolerations, and avoid topology-breaking constraints.
Ote Binary Stdout Contract ✅ Passed Addon Operator is a deployed Kubernetes operator, not an OTE test binary. OTE stdout contract applies only to OpenShift test binaries, not deployed operators.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests added. Custom check applies only to Ginkgo tests (It(), Describe(), Context()), but added tests use testify/suite with testing.T framework instead.
No-Weak-Crypto ✅ Passed PR only modifies OWNERS configuration files (removed apahim from approvers/reviewers list, updated OWNERS_ALIASES). No cryptographic code is changed; check is not applicable to configuration files.
Container-Privileges ✅ Passed PR modifies only OWNERS files. No K8s manifests with privileged: true, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation: true found. Deployments properly configured.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data exposed in logs. Log statements mentioning tokens/secrets only log constant strings, not secret values.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.37%. Comparing base (f5b3118) to head (ec69a1c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   59.24%   59.37%   +0.12%     
==========================================
  Files          62       62              
  Lines        4125     4143      +18     
==========================================
+ Hits         2444     2460      +16     
  Misses       1532     1532              
- Partials      149      151       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ajpantuso Ajpantuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ajpantuso

Copy link
Copy Markdown
Contributor

/override ci/prow/lint

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ajpantuso, apahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@Ajpantuso: Overrode contexts on behalf of Ajpantuso: ci/prow/lint

Details

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b48e996 and 2 for PR HEAD ec69a1c in total

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@apahim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check ec69a1c link true /test precommit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants