Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2029416: UPSTREAM: 572: User credentials provided by CredentialsOperator #7

Merged
merged 1 commit into from Jan 21, 2022
Merged

Bug 2029416: UPSTREAM: 572: User credentials provided by CredentialsOperator #7

merged 1 commit into from Jan 21, 2022

Conversation

jsafrane
Copy link

This is heavily tailored patch from upstream, I basically took pkg/utils/auth.go from master.

I can see:

  • In the driver logs:
    • With this PR: 
      time="2022-01-20T10:24:40Z" level=info msg="Get AK: use Credential AK"
    • Before this PR: 
      time="2022-01-20T11:01:08Z" level=info msg="Get AK: use STS"
  • When I provision a volume, in Alibaba cloud logs (Elastic Compute Service -> Operation Logs):
    • With this PR:
      • Operation Name: CreateDisk
      • User Name: jsafrane-1-28wl2-openshift-cluster-csi-drivers-alibaba-disk-cred
    • Before this PR:
      • Operation Name: CreateDisk
      • User Name: jsafrane-1-28wl2-role-master:vm-ram-i-gw8h04yo5307lunypvo3
      • (i.e. Node's identity is used to provision the volume)

cc @openshift/storage

@jsafrane
UPSTREAM: 572: Adapt to openshift, read ak from /root/.alibabacloud/c…
89e4837 
…redentials path

This is heavily tailored patch from upstream, I basically took
pkg/utils/auth.go from master.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

@jsafrane: This pull request references Bugzilla bug 2029416, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ropatil010

In response to this:

Bug 2029416: UPSTREAM: 572: User credentials provided by CredentialsOperator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
bertinatto
bertinatto reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ac83e4b into openshift:master Jan 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2022

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2029416 has been moved to the MODIFIED state.

In response to this:

Bug 2029416: UPSTREAM: 572: User credentials provided by CredentialsOperator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@ropatil010 ropatil010 Awaiting requested review from ropatil010

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsafrane @bertinatto @openshift-merge-robot