We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened:
Trying to plug the broker to an internal Docker registry throught the "apiv2" adapter.
The token with the JSON field name "token" returned by the registry is not taken into account by the broker.
My registry doesn't implement the OAuth compatible name "access_token".
What you expected to happen:
The token should be accepted. See https://docs.docker.com/registry/spec/auth/token/
The broker only accepts OAuth tokens with the name "access_token" (see code in vendor/github.com/automationbroker/bundle-lib/registries/adapters https://github.com/automationbroker/bundle-lib/tree/master/registries/adapters).
How to reproduce it:
The text was updated successfully, but these errors were encountered:
+1
Sorry, something went wrong.
see: automationbroker/bundle-lib#174
@toplac are you saying that it is not in the canary tag of the image referenced in this comment?
canary
Sorry, my comment should have been a hint, that this is fixed and available
😎 I must need coffee because I don't know how I read it any other way than you intended. The fix was brought into the broker via #1167
@eriknelson can we close this?
The token part is OK now, thanks.
dymurray
No branches or pull requests
Bug:
What happened:
Trying to plug the broker to an internal Docker registry throught the "apiv2" adapter.
The token with the JSON field name "token" returned by the registry is not taken into account by the broker.
My registry doesn't implement the OAuth compatible name "access_token".
What you expected to happen:
The token should be accepted. See https://docs.docker.com/registry/spec/auth/token/
The broker only accepts OAuth tokens with the name "access_token" (see code in vendor/github.com/automationbroker/bundle-lib/registries/adapters https://github.com/automationbroker/bundle-lib/tree/master/registries/adapters).
How to reproduce it:
The text was updated successfully, but these errors were encountered: