Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIV2 adapter should accept token with name "token" #1097

Closed
sebastien-prudhomme opened this issue Sep 25, 2018 · 7 comments
Closed

APIV2 adapter should accept token with name "token" #1097

sebastien-prudhomme opened this issue Sep 25, 2018 · 7 comments
Assignees
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4

Comments

@sebastien-prudhomme
Copy link

sebastien-prudhomme commented Sep 25, 2018

Bug:

What happened:

Trying to plug the broker to an internal Docker registry throught the "apiv2" adapter.

The token with the JSON field name "token" returned by the registry is not taken into account by the broker.

My registry doesn't implement the OAuth compatible name "access_token".

What you expected to happen:

The token should be accepted. See https://docs.docker.com/registry/spec/auth/token/

The broker only accepts OAuth tokens with the name "access_token" (see code in vendor/github.com/automationbroker/bundle-lib/registries/adapters https://github.com/automationbroker/bundle-lib/tree/master/registries/adapters).

How to reproduce it:

@sjahreis
Copy link

+1

@jmrodri jmrodri added the 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 label Oct 2, 2018
@dymurray dymurray self-assigned this Oct 2, 2018
@toplac
Copy link

toplac commented Jan 23, 2019

see: automationbroker/bundle-lib#174

@djzager
Copy link
Member

djzager commented Jan 23, 2019

@toplac are you saying that it is not in the canary tag of the image referenced in this comment?

@toplac
Copy link

toplac commented Jan 23, 2019

Sorry, my comment should have been a hint, that this is fixed and available

@djzager
Copy link
Member

djzager commented Jan 23, 2019

😎 I must need coffee because I don't know how I read it any other way than you intended. The fix was brought into the broker via #1167

@djzager
Copy link
Member

djzager commented Jan 23, 2019

@eriknelson can we close this?

@sebastien-prudhomme
Copy link
Author

The token part is OK now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4
Projects
None yet
Development

No branches or pull requests

6 participants