Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: add rate limiter to the broker's API handler #1098

Closed
jmrodri opened this issue Oct 2, 2018 · 4 comments
Closed

RFE: add rate limiter to the broker's API handler #1098

jmrodri opened this issue Oct 2, 2018 · 4 comments
Assignees
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 feature has-bugzilla This issue has a corresponding bugzilla lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jmrodri
Copy link
Contributor

jmrodri commented Oct 2, 2018

Feature:

There are times that APIs are getting called for what seems like forever. For example, a provision fails which will cause the service catalog to issue a deprovision. If the deprovision fails, this cycle can continue forever. Normally the broker is configured to save failed APB pods so that they may be debugged later. At the moment we save ALL APB pods which can create a lot of unwanted namespaces.

There are 2 parts to this feature:

  1. look into only saving the latest failed APB pod. For example, if a deprovision call fails, and a subsequent one fails with the same parameters, then we should delete the older pod and keep the newer one

  2. rate limit the API, such that after a certain period of time we don't spawn new pods at all for the API and just return that it failed always. Basically becoming a no-op.

@jmrodri jmrodri added the 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 label Oct 2, 2018
@jmrodri jmrodri self-assigned this Oct 2, 2018
@jmrodri
Copy link
Contributor Author

jmrodri commented Nov 12, 2018

Downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1649076

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 20, 2020

/close

@openshift-ci-robot
Copy link

@jmrodri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 feature has-bugzilla This issue has a corresponding bugzilla lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants