Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker ansible locks up determining if local_openshift_enabled #1105

Closed
eriknelson opened this issue Oct 12, 2018 · 7 comments
Closed

Broker ansible locks up determining if local_openshift_enabled #1105

eriknelson opened this issue Oct 12, 2018 · 7 comments
Assignees
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 has-bugzilla This issue has a corresponding bugzilla kind/bug Categorizes issue or PR as related to a bug. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯

Comments

@eriknelson
Copy link
Contributor

So it looks like under certain circumstances, the broker's ansible will completely lock up and hang when dynamically trying to determine if the local openshift adapter is enabled. Currently it uses the following line set in the defaults file:

broker_local_openshift_enabled: "{{ ('image.openshift.io' in lookup('k8s', cluster_info='api_groups')) | bool }}"

This task will hang as it tries to build the config: https://github.com/openshift/ansible-service-broker/blob/master/ansible_role/tasks/build_config.yml#L19

It's not clear to me exactly why or when this shows up, because I've seen it work in some circumstances and not in others. Right now, in the current OLM setup with catasb, you can't deploy a broker due to this issue unless you override the var with broker_local_openshift_enabled: true.

Here are the operator logs: https://gist.github.com/eriknelson/0b6d82a2de646374dd565f84ccbb9824

@jmontleon
Copy link
Contributor

May be related to: ansible/ansible-runner#154

Possible workaround: https://github.com/ansibleplaybookbundle/apb-base/pull/52/files

@jmontleon
Copy link
Contributor

After some testing this is most like due to kubernetes-client/python#653

We can pin the versions of python openshift and kubernetes until the underlying problem in python kubernetes is fixed. water-hole/ansible-operator#56

@jmontleon jmontleon added the kind/bug Categorizes issue or PR as related to a bug. label Oct 22, 2018
@jmrodri jmrodri added the 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 label Oct 30, 2018
@jmontleon
Copy link
Contributor

Appears to be fixed in kubernetes 8.0.0 and openshift 0.8.0, which are both now released.

@openshift-ci-robot openshift-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 8, 2018
@djzager djzager removed the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 8, 2018
@fabianvf
Copy link
Member

fabianvf commented Nov 8, 2018

No that label seems appropriate

@djzager
Copy link
Member

djzager commented Nov 8, 2018

/shrug

@openshift-ci-robot openshift-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Nov 8, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Nov 12, 2018

Downstream bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1649078

@jmrodri jmrodri added the has-bugzilla This issue has a corresponding bugzilla label Nov 12, 2018
@jmontleon
Copy link
Contributor

kubernetes 8.0.0 and openshift 0.8.0 have been built upstream and downstream and look to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 has-bugzilla This issue has a corresponding bugzilla kind/bug Categorizes issue or PR as related to a bug. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

No branches or pull requests

6 participants