Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbind last_operation response always responds with 410 Gone #709

Closed
mhrivnak opened this issue Jan 29, 2018 · 1 comment · Fixed by #765
Closed

unbind last_operation response always responds with 410 Gone #709

mhrivnak opened this issue Jan 29, 2018 · 1 comment · Fixed by #765
Labels
3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2

Comments

@mhrivnak
Copy link
Member

What happened:

When an async unbind operation is in-progress, the last_operation endpoint incorrectly responds with a 410 Gone response code.

This is on the release-1.1 branch.

What you expected to happen:
The spec says a 410 response to a last_operation request is "Appropriate only for asynchronous delete operations. The Platform MUST consider this response a success and remove the resource from its database."

In our case, a 410 response does not indicate success because it gets returned even while the job is in-progress. Thus our response is misleading.

How to reproduce it:
Use the last_operation endpoint to query the state of an in-progress unbind operation.

Cause
This is likely caused by the fact that when the DELETE is requested on the binding, the BindInstance is deleted from etcd before even a 202 response is returned. It may be better to do that deleting at the end of the unbind job.

@rthallisey rthallisey added bug 3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels Jan 29, 2018
@philipgough
Copy link
Contributor

/assign I'll take a stab at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants