Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker needs more robust error passing between broker methods and the handlers #730

Closed
eriknelson opened this issue Feb 5, 2018 · 2 comments
Assignees
Labels
tech-debt triage/unresolved Indicates an issue that can not or will not be resolved. unplanned Issue is recognized but not planned for any release

Comments

@eriknelson
Copy link
Contributor

eriknelson commented Feb 5, 2018

The way we're passing errors back from the broker layer to the handlers is not very flexible and should be improved. Today, the handlers basically just switch on the error string contents to detect which type was returned, but this doesn't leave any room for variability in the descriptions passed to the platform.

We need to start thinking about broker error types, preferably OSB centric. High level OSB Errors types should be defined so the broker can return them and the right thing just happens at the HTTP layer. Right now, we're employing the bad habit of extending broker.go return signatures to continue to report additional values.

My desire is to be able to flexibly introduce a new BrokerError type that a broker.go returns in the event of a semantic error, and have the handler layer generically understand how to deal with that. It probably involves some set of methods like StatusCode(), Description(), etc.

@eriknelson eriknelson self-assigned this Feb 5, 2018
@eriknelson
Copy link
Contributor Author

eriknelson commented Feb 5, 2018

I'm happy to take this one, because it always bugs me :)

@jmrodri jmrodri changed the title Broker needs more rubust error passing between broker methods and the handlers Broker needs more robust error passing between broker methods and the handlers Feb 6, 2018
@rthallisey rthallisey added the 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 label Feb 7, 2018
@rthallisey rthallisey added 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 and removed 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels Mar 13, 2018
@jmrodri jmrodri added 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 and removed 3.11 | release-1.3 Kubernetes 1.11 | Openshift 3.11 | Broker release-1.3 labels Jul 23, 2018
@jmrodri jmrodri added unplanned Issue is recognized but not planned for any release triage/unresolved Indicates an issue that can not or will not be resolved. and removed 3.12 | release-1.4 Kubernetes 1.12 | Openshift 3.12 | Broker release-1.4 labels Nov 12, 2018
@jmrodri
Copy link
Contributor

jmrodri commented Nov 12, 2018

Closing as won't fix.

@jmrodri jmrodri closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt triage/unresolved Indicates an issue that can not or will not be resolved. unplanned Issue is recognized but not planned for any release
Projects
None yet
Development

No branches or pull requests

3 participants